From: Jeff King <peff@peff.net>
Date: Tue, 12 Jun 2012 12:34:54 GMT
Subject: Re: [PATCH] t: Replace 'perl' by $PERL_PATH
Message-ID: <20120612123454.GA25407@sigill.intra.peff.net>
In-Reply-To: <7v1ull7j9k.fsf@alter.siamese.dyndns.org>

On Mon, Jun 11, 2012 at 12:15:03PM -0700, Junio C Hamano wrote:

> There was already this discussion:
> 
>     http://thread.gmane.org/gmane.comp.version-control.git/132560/focus=132561
> 
> which basically dismissed effort along this line with "If the perl
> in your PATH is so broken that it can't be used for simple helpers,
> then you should fix your PATH."

That sounds like something I would say. :)

> I personally do not mind if we do this consistently, but I am not
> sure your $PERL_PATH that is not quoted is the right way to invoke
> it; look for PERL_PATH in t/ to see the existing uses.

My biggest concern is placing an extra portability burden on
test-writers (who will inevitably forget, and won't notice because what
they are doing is only broken on obscure systems). Is there a way we can
hide this behind a perl() shell function or something?

-Peff