From: konglu@minatec.inpg.fr
Date: Mon, 11 Jun 2012 21:07:20 GMT
Subject: Re: [PATCHv3 3/6] Test file for git-remote-mediawiki clone
Message-ID: <20120611230720.Horde.Xx4mVHwdC4BP1l4IcI6RWrA@webmail.minatec.grenoble-inp.fr>
In-Reply-To: <1339446526-22397-3-git-send-email-simon.cathebras@ensimag.imag.fr>


Simon Cathebras <simon.cathebras@ensimag.imag.fr> a écrit :


> +test_expect_success 'Git clone creates the git log expected with one file' '
> +	wiki_reset &&
> +	cd '"$TRASH_DIR"' &&
> +	rm -rf mw_dir &&
> +	wiki_editpage foo "this is not important" false -c cat -s "this  
> must be the same" &&
> +	git clone mediawiki::http://localhost/wiki mw_dir &&
> +	cd mw_dir &&
> +	git log --format=%s HEAD^..HEAD > log.tmp &&
> +	echo "this must be the same" > msg.tmp &&
> +	diff -b log.tmp msg.tmp &&
> +	cd .. &&
> +	rm -rf mw_dir
> +'
> +

It's best not to chdir around outside a subshell (same comment for all the
other tests)

BTW, please be aware of the whitespaces (the first 5 parts of your patch are
full of it - couldn't apply the last one because of the special  
characters, maybe
something that i haven't configure, i don't know).