From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 10 Jun 2012 18:44:10 GMT
Subject: Re: [PATCH] lessen the impression of unexpectedness on remote hangup
Message-ID: <20120610184410.GA1115@burratino>
In-Reply-To: <20120610182310.GB2427@book.hvoigt.net>

Hi,

Heiko Voigt wrote:

> --- a/pkt-line.c
> +++ b/pkt-line.c
> @@ -141,7 +141,7 @@ static void safe_read(int fd, void *buffer, unsigned size)
>  	if (ret < 0)
>  		die_errno("read error");
>  	else if (ret < size)
> -		die("The remote end hung up unexpectedly");
> +		die("The remote end hung up");

Looks good.  Incidentally, maybe this would be a good excuse to
revisit [1].

If I remember correctly, the conclusion of that discussion was that
--informative-errors is a good default for the git daemon as long as

 - there is some warning when using it without --base-path
 - there is an easy way to turn it off
 - we communicate the change clearly and in advance

Hope that helps,
Jonathan

[1] http://thread.gmane.org/gmane.comp.version-control.git/183604