From: Jonathan Nieder Date: Sun, 10 Jun 2012 07:38:03 GMT Subject: [PATCH] git-blame.el: use mapc instead of mapcar Message-ID: <20120610073803.GA29461@burratino> In-Reply-To: <2608010.fNV39qBMLu@descartes> From: Rüdiger Sonderfeld Using mapcar here is a waste of memory because the mapped result is not used. Noticed by emacs ("Warning: `mapcar' called for effect"). [jn: split from a larger patch, with new description] Signed-off-by: Rüdiger Sonderfeld Signed-off-by: Jonathan Nieder --- In January, Rüdiger Sonderfeld wrote: > Replace mapcar with mapc because accumulation of the results was not > needed. (git-blame-cleanup) > > Replace two occurrences of (save-excursion (set-buffer buf) ...) > with (with-current-buffer buf ...). (git-blame-filter and > git-blame-create-overlay) > > Replace goto-line with (goto-char (point-min)) (forward-line (1- > start-line)). According to the documentation of goto-line it should > not be called from elisp code. (git-blame-create-overlay) > > Signed-off-by: Rüdiger Sonderfeld > --- > contrib/emacs/git-blame.el | 10 ++++------ > 1 files changed, 4 insertions(+), 6 deletions(-) Thanks again, and sorry for the long silence. I'd prefer to see someone more knowledgeable than I am about elisp submit the other two fixes. This one is simple enough that I can vouch for it, though. One out of three is not that bad, I guess. :) Thoughts? Jonathan contrib/emacs/git-blame.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el index d351cfb6..37d797e1 100644 --- a/contrib/emacs/git-blame.el +++ b/contrib/emacs/git-blame.el @@ -304,7 +304,7 @@ See also function `git-blame-mode'." (defun git-blame-cleanup () "Remove all blame properties" - (mapcar 'delete-overlay git-blame-overlays) + (mapc 'delete-overlay git-blame-overlays) (setq git-blame-overlays nil) (remove-git-blame-text-properties (point-min) (point-max))) -- 1.7.10