From: konglu@minatec.inpg.fr
Date: Thu, 07 Jun 2012 20:44:59 GMT
Subject: Re: rebase [-i --exec | -ix] <CMD>...
Message-ID: <20120607224459.Horde.GLRVL3wdC4BP0RLLE1gTU0A@webmail.minatec.grenoble-inp.fr>
In-Reply-To: <m2k3zivp0c.fsf@igel.home>


Andreas Schwab <schwab@linux-m68k.org> a écrit :

> konglu@minatec.inpg.fr writes:
>
>> As you pointed out, the problem seems to come from this line
>> 	tmp=$(sed "/^pick .*/i\exec $i" "$1")
>> I think that the dquote here doesn't work on MacOS, though i've
>> never tried it. Anyway, even if it's not the problem, this kind
>> of quoting is quite odd so it will be removed in the next patch
>> (I do not see other reasons of the issue, as sed's i command should
>> work on MacOS).
>
> You need to put a newline after the backslash.

That's what we originally did. Though we did it with indentations:
         tmp=$(sed "/^pick .*/i\
                            exec $i" "$1")
Should it be put that way (without indentations) ?
         tmp=$(sed "/^pick .*/i\
exec $i" "$1")

Thanks,

Lucien Kong