From: Jeff King <peff@peff.net>
Date: Wed, 06 Jun 2012 13:43:21 GMT
Subject: Re: [RFC 4/4] Add cat-blob report pipe from fast-import to remote-helper.
Message-ID: <20120606134320.GC2597@sigill.intra.peff.net>
In-Reply-To: <5801019.gWQEmI8V81@flobuntu>

On Wed, Jun 06, 2012 at 12:16:25AM +0200, Florian Achleitner wrote:

> On Tuesday 05 June 2012 04:14:02 Jeff King wrote:
> > Is there a reason that the patch unconditionally creates the pipe in
> > get_helper? I.e., isn't it specific to the get_importer code path? It
> > feels a little hacky to have it infect the other code paths.
> 
> I agree, it's a bit hacky. For me as a newbee, it was just a way to make fast-
> import have the pipe it needs. I didn't know about the history of the 
> preexec_cb as a fix for a bug in less.
> 
> The pipe is created unconditionally, because at the fork-time of the remote-
> helper it is not known whether the import command will be used later together 
> with fast-import, or not. (and later, there's no way, I think).
> Helpers that don't use the pipe could simply ignore it.

Good point. I think we really are stuck with doing it in every case,
unless we want to turn to something that can be opened after the fact
(like a fifo).

-Peff