From: Jeff King <peff@peff.net>
Date: Tue, 05 Jun 2012 11:22:09 GMT
Subject: Re: [PATCH 3/3] api-credentials.txt: add "see also" section
Message-ID: <20120605112209.GA1976@sigill.intra.peff.net>
In-Reply-To: <vpqaa0ij98q.fsf@bauges.imag.fr>

On Tue, Jun 05, 2012 at 01:20:21PM +0200, Matthieu Moy wrote:

> > diff --git a/Documentation/Makefile b/Documentation/Makefile
> > index 14286cb..b3693c8 100644
> > --- a/Documentation/Makefile
> > +++ b/Documentation/Makefile
> > @@ -280,6 +280,7 @@ technical/api-index.txt: technical/api-index-skel.txt \
> >  	technical/api-index.sh $(patsubst %,%.txt,$(API_DOCS))
> >  	$(QUIET_GEN)cd technical && '$(SHELL_PATH_SQ)' ./api-index.sh
> >  
> > +technical/%.html: ASCIIDOC_EXTRA += -a git-relative-html-prefix=../
> >  $(patsubst %,%.html,$(API_DOCS) technical/api-index): %.html : %.txt
> >  	$(QUIET_ASCIIDOC)$(ASCIIDOC) -b xhtml11 -f asciidoc.conf \
> >  		$(ASCIIDOC_EXTRA) -agit_version=$(GIT_VERSION) $*.txt
> > @@ -333,6 +334,7 @@ $(patsubst %,%.html,$(ARTICLES)) : %.html : %.txt
> >  
> >  WEBDOC_DEST = /pub/software/scm/git/docs
> >  
> > +howto/%.html: ASCIIDOC_EXTRA += git-relative-html-prefix=../
> 
> Don't you miss a "-a" between += and git-relative-html-prefix?

Ugh, thank you. I added the line for howto/* while doing a final review
on the patch, but running "make" again did not actually trigger a
rebuild).

-Peff