From: Ted Ts'o Date: Fri, 01 Jun 2012 20:38:36 GMT Subject: Re: GIT PULL] ext4 updates for 3.5 Message-ID: <20120601203836.GB19987@thunk.org> In-Reply-To: <7v4nqu3lhy.fsf@alter.siamese.dyndns.org> One other thought. One of the reasons why I used "dev" and not "ext4_for_linus" in my git request-pull command line was because that several months ago I had created a branch called ext4_for_linus, and I hadn't gotten around to deleting it, so I figured I'd just use "dev" instead, since it was non-ambiguous. If there is a case where there is both tag and a branch with the same name, it might be a good idea for request-pull not just to issue a warning, since the user might not notice the warning, but to just abort --- and make the user explicitly type refs/tags/ext4_for_linus or refs/heads/ext4_for_linus. Most of the time if the user ignores the warning about the ambiguity, it's not such a big deal, but in the case of a pull-request, he or she is going to be possibly embarassing themself publically, so it might be better to explicitly list the reason why a non-qualified refname is ambiguous and force the user to pick the right one. It's a minor point, and usually I double check the commit id in the pull request just to be sure, so it might be considered too much of coddling the user, but it might be a good safety check to add. - Ted