From: Jonathan Nieder Date: Thu, 31 May 2012 20:31:02 GMT Subject: Re: [PATCH 2/6] reflog: remove i18n legos in pruning message Message-ID: <20120531203102.GA27332@burratino> In-Reply-To: <7vlik86xqd.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > These are for human consumption; they used to go to standard error > stream back when it was written at 4264dc1 (git reflog expire, > 2006-12-19). Good. Thanks for clarifying and for looking that up. Why was this changed to write to standard output in 1389d9dd (reflog expire --fix-stale, 2007-01-06)? Would changing it back some time to follow the usual "progress and diagnostics go to stderr" pattern be worthwhile? --- builtin/reflog.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git i/builtin/reflog.c w/builtin/reflog.c index 062d7dad..90e820a0 100644 --- i/builtin/reflog.c +++ w/builtin/reflog.c @@ -327,11 +327,11 @@ static int expire_reflog_ent(unsigned char *osha1, unsigned char *nsha1, hashcpy(cb->last_kept_sha1, nsha1); } if (cb->cmd->verbose) - printf("keep %s", message); + fprintf(stderr, "keep %s", message); return 0; prune: if (!cb->newlog || cb->cmd->verbose) - printf("%sprune %s", cb->newlog ? "" : "would ", message); + fprintf(stderr, "%sprune %s", cb->newlog ? "" : "would ", message); return 0; } @@ -646,10 +646,10 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix) if (cb.stalefix) { init_revisions(&cb.revs, prefix); if (cb.verbose) - printf("Marking reachable objects..."); + fprintf(stderr, "Marking reachable objects..."); mark_reachable_objects(&cb.revs, 0, NULL); if (cb.verbose) - putchar('\n'); + fputc('\n', stderr); } if (do_all) { --