From: Jeff King Date: Thu, 24 May 2012 23:32:52 GMT Subject: [PATCH 7/7] format-patch: do not use bogus email addresses in message ids Message-ID: <20120524233251.GG11084@sigill.intra.peff.net> In-Reply-To: <20120524232515.GA11054@sigill.intra.peff.net> We can ask git_committer_info to be strict about coming up with an email, which will die automatically on a poorly configured machine. This is better than letting invalid message-ids into the wild. Signed-off-by: Jeff King --- builtin/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/log.c b/builtin/log.c index d86bca3..906dca4 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -741,7 +741,7 @@ static void gen_message_id(struct rev_info *info, char *base) struct strbuf buf = STRBUF_INIT; strbuf_addf(&buf, "%s.%lu.git.%s", base, (unsigned long) time(NULL), - git_committer_info(IDENT_NO_NAME|IDENT_NO_DATE)); + git_committer_info(IDENT_NO_NAME|IDENT_NO_DATE|IDENT_STRICT)); info->message_id = strbuf_detach(&buf, NULL); } -- 1.7.10.1.25.g7031a0f