From: Jeff King Date: Thu, 24 May 2012 23:26:32 GMT Subject: [PATCH 1/7] ident: refactor empty ident error message Message-ID: <20120524232632.GA11084@sigill.intra.peff.net> In-Reply-To: <20120524232515.GA11054@sigill.intra.peff.net> There's on point in printing the name, since it is by definition the empty string if we have reached this code path. Instead, let's be more clear that we are complaining about the empty name, but still show the email address that it is attached to (since that may provide some context to the user). Signed-off-by: Jeff King --- As I mentioned in the cover letter, this one is optional. But I think it makes sense. ident.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ident.c b/ident.c index e279039..f5160e1 100644 --- a/ident.c +++ b/ident.c @@ -281,7 +281,7 @@ const char *fmt_ident(const char *name, const char *email, if (error_on_no_name) { if (name == git_default_name.buf) fputs(env_hint, stderr); - die("empty ident %s <%s> not allowed", name, email); + die("empty ident name (for <%s>) not allowed", email); } pw = xgetpwuid_self(); name = pw->pw_name; -- 1.7.10.1.25.g7031a0f