From: SZEDER Gábor <szeder@ira.uka.de>
Date: Thu, 24 May 2012 20:47:26 GMT
Subject: Re: [PATCH 2/2] completion: split __git_ps1 into a separate script
Message-ID: <20120524204726.GB2052@goldbirke>
In-Reply-To: <1337719600-7361-3-git-send-email-felipe.contreras@gmail.com>


Hi,


On Tue, May 22, 2012 at 10:46:40PM +0200, Felipe Contreras wrote:
> bash-completion 1.90 shipped 

That's still beta, right?  (or the bash-completion website is out of
date...)

> with support to load completions
> dynamically[1], which means the git completion script wouldn't be loaded
> until the user types 'git <tab>'--this creates a problem to people using
> __git_ps1(); that function won't be available when the shell is first
> created.
> 
> For now distributions have workarounded this issue by moving the git
> completion to the "compatdir"[2]; this of course is not ideal.
> 
> The solution, proposed by Kerrick Staley[3], is to split the git script
> in two; the part that deals with __git_ps1() in one (i.e.
> git-prompt.sh), and everything else in another (i.e.
> git-completion.bash).

This breaks existing setups, where the user installs
git-completion.bash with 'make install', or where the user sources
git-completion.bash directly from the repository.


Best,
Gábor