From: Eric Wong <normalperson@yhbt.net>
Date: Thu, 24 May 2012 03:02:55 GMT
Subject: Re: [PATCH 1/2] git-svn.perl: consider all ranges for a given merge, instead of only tip-by-tip
Message-ID: <20120524030255.GA23382@dcvr.yhbt.net>
In-Reply-To: <1337820046-4791-1-git-send-email-stevenrwalter@gmail.com>

Steven Walter <stevenrwalter@gmail.com> wrote:

I'll wait for input on others who understand mergeinfo better than
I do to chime in on the actual changes.  Some nits on the tests:

> +# Copyright (c) 2010 Steven Walter

2010?

> +test_expect_success 'verify merge commit' 'x=$(git rev-parse HEAD^2) &&
> +	y=$(git rev-parse branch2) &&
> +	[ $x == $y ]

== is a bash-ism, and we prefer 'test'.  A single '=' works fine here,
but it's probably better to prefix and quote if you're paranoid:

	test "x$x" = "x$y"