From: Jeff King <peff@peff.net>
Date: Mon, 21 May 2012 22:24:40 GMT
Subject: Re: remove_duplicates() in builtin/fetch-pack.c is O(N^2)
Message-ID: <20120521222440.GB22664@sigill.intra.peff.net>
In-Reply-To: <7vvcjp6vbl.fsf@alter.siamese.dyndns.org>

On Mon, May 21, 2012 at 03:08:46PM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > Anyway, my point is that we don't even have to talk about "reasonable"
> > or "absurd".  Git should be fast even on absurd cases,...
> 
> I agree with you 98%.
> 
> If we can make Git fast even on "absurd" cases without penalizing less
> extreme and boring cases and/or maintainability of the code, we should
> strive to do so.  And I think the codepaths mentioned in this thread falls
> into that category.
> 
> The remaining 2% is only to allow me to say that we reserve the right to
> label cases "absurd" when it is extremely painful to support without
> penalizing the code and performance of less extreme and boring cases ;-)

Yes, I should be more careful with what I promise. :) I agree very much
that we should reserve that right.

-Peff