From: Jeff King <peff@peff.net>
Date: Thu, 10 May 2012 20:22:27 GMT
Subject: Re: [PATCH 1/2] Change error messages in ident.c...
Message-ID: <20120510202227.GA30965@sigill.intra.peff.net>
In-Reply-To: <7vipg3n6pu.fsf@alter.siamese.dyndns.org>

On Thu, May 10, 2012 at 01:04:13PM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > I am also tempted to suggest that we simply replace the static buffers
> > with dynamic strbufs.
> 
> Yeah, I think that is a proper approach for this issue, as it will make
> two of these messages unnecessary (or all?  I couldn't think of a way
> to deal with missing getpwent case myself, though).

It doesn't get rid of the "you don't exist" message, and I think just
dying there makes sense.  But that is actually the one that I consider
the most likely to happen in practice, and should probably have a more
useful error message.

-Peff