From: Eric Wong <normalperson@yhbt.net>
Date: Fri, 27 Apr 2012 08:21:18 GMT
Subject: Re: [PATCH 1/2] git-svn: use platform specific auth providers
Message-ID: <20120427082118.GA7257@dcvr.yhbt.net>
In-Reply-To: <1335468843-24653-1-git-send-email-matthijs@stdin.nl>

Matthijs Kooijman <matthijs@stdin.nl> wrote:
> On Linux, this makes authentication using passwords from gnome-keyring
> and kwallet work (only the former was tested). On Mac OS X, this allows
> using the OS X Keychain.

Thanks, this looks good.  Can you add a Signed-off-by? (you can just
reply here and I'll add it to the commit message when pushing.

Otherwise, consider this Acked-by: Eric Wong <normalperson@yhbt.net>

> +	# earlier 1.6.x versions would segfault, and <= 1.5.x didn't have
> +	# this function
> +	if ($SVN::Core::VERSION gt '1.6.12') {

Thank you for documenting this segfault, btw.