From: Jeff King <peff@peff.net>
Date: Thu, 26 Apr 2012 13:08:54 GMT
Subject: Re: [PATCH] Try an uppercase version of $prot_proxy env var
Message-ID: <20120426130854.GC27785@sigill.intra.peff.net>
In-Reply-To: <4F994AC3.2070708@seap.minhap.es>

On Thu, Apr 26, 2012 at 03:16:51PM +0200, Nelson Benitez Leon wrote:

> Try an uppercase version of $prot_proxy env var when thelowercase version 
> is not found.
> [...]
> diff --git a/http.c b/http.c
> index 6a98195..bf9c20e 100644
> --- a/http.c
> +++ b/http.c
> @@ -329,6 +329,13 @@ static CURL *get_curl_handle(const char *url)
>  		strbuf_addf(&buf, "%s_proxy", cre_url.protocol);
>  		env_proxy_var = strbuf_detach(&buf, NULL);
>  		env_proxy = getenv(env_proxy_var);
> +		if (!env_proxy) {
> +			char *p;
> +			for (p = env_proxy_var; *p; p++) {
> +				*p = toupper(*p);
> +			}
> +			env_proxy = getenv(env_proxy_var);
> +		}

Don't we explicitly not want to do this when the protocol is http? Curl
doesn't respect HTTP_PROXY.

-Peff