From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 25 Apr 2012 15:25:58 GMT
Subject: Re: [PATCH 03/10] i18n: mark relative dates for translation
Message-ID: <20120425152558.GC31026@burratino>
In-Reply-To: <CACsJy8Ae_9wEoNmP81Gqu5kOMGrEKSN9PMvoRXbKh8TnwGVt0A@mail.gmail.com>

Nguyen Thai Ngoc Duy wrote:
> 2012/4/25 Junio C Hamano <gitster@pobox.com>:

>>> +     strbuf_addf(timebuf,
>>> +              Q_("%lu year ago", "%lu years ago", (diff + 183) / 365),
>>> +              (diff + 183) / 365);
>>>  }
>>
>> This is just a tangent, but could we possibly come here and say "1 year
>> ago"?
>
> Nice catch. Singular form here is unnecessary.

I think Junio meant

			Q_("1 year ago", "%lu years ago", ...)

That sound reasonable to me.  My only worry is a small one: what
happens if we want to change the %lu to some other format specifier
some day?  Will xgettext be smart enough to let translators know
without the msgid changing?