From: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 20 Apr 2012 19:56:34 GMT
Subject: Re: [PATCH v8 2/4] git-cherry-pick: Add keep-redundant-commits option
Message-ID: <20120420195634.GE15966@hmsreliant.think-freely.org>
In-Reply-To: <xmqqvckumcoq.fsf@junio.mtv.corp.google.com>

On Fri, Apr 20, 2012 at 12:21:41PM -0700, Junio C Hamano wrote:
> Looks good, modulo perhaps these fixes on top.
> 
>  - It would be better to say "dropped" to stress that we inspect and
>    actively discard, instead of saying "ignored".
> 
>  - There is no need to use "changeset", the term glossary even
>    discourages, to make sense of the sentence.
> 
>  - There was still a stray keep_if_made_empty.
> 
>  - s/Add keep/add keep/ on the title as well.
> 
> No need to resend, unless you have fixes other than the following does.
> 
Nope I'm good, if you can work those changes in.  Thanks!
Neil

>