From: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 18 Apr 2012 10:49:19 GMT
Subject: Re: [PATCH v6 2/4] git-cherry-pick: Add keep-redundant-commits option
Message-ID: <20120418104919.GC22172@hmsreliant.think-freely.org>
In-Reply-To: <20120417214521.GB19908@ecki>

On Tue, Apr 17, 2012 at 11:45:22PM +0200, Clemens Buchacher wrote:
> On Tue, Apr 17, 2012 at 02:20:07PM -0400, Neil Horman wrote:
> >
> > +	if (!empty && !opts->keep_redundant_commits && index_unchanged)
> > +			/*
> > +			 * The head tree and the index match
> > +			 * meaning the commit is empty.  Since it wasn't created
> > +			 * empty (based on the previous test), we can conclude
> > +			 * the commit has been made redundant.  Since we don't
> > +			 * want to keep redundant commits, we can just return
> > +			 * here, skipping this commit
> > +			 */
> > +			return 0;
> 
> You can remove one level of indentation (yay!).
>
Doh!  Thanks.
Neil