From: Jeff King <peff@peff.net>
Date: Wed, 18 Apr 2012 07:27:50 GMT
Subject: Re: [PATCH] Do not use SHELL_PATH from build system in prepare_shell_cmd on Windows
Message-ID: <20120418072615.GA2217@sigill.intra.peff.net>
In-Reply-To: <4F8E539F.7030902@viscovery.net>

On Wed, Apr 18, 2012 at 07:39:43AM +0200, Johannes Sixt wrote:

> > It sounds like the real problem is not the use of a configurable shell,
> > but rather the use of an absolute path. Should you maybe try to pass the
> > basename of SHELL_PATH? Or maybe that is not even worth worrying about,
> > as somebody on Windows is not going to ever set SHELL_PATH, since it is
> > not like they are working around a non-POSIX "sh" included with the
> > operating system (which is why people on Solaris typically set
> > SHELL_PATH).
> 
> I thought about offering a customization point, but decided that it is not
> worth the hassle: Most people download an installer, then the installer
> can set up the PATH so that "sh" is not broken or something entirely
> unrelated. And those who build git themselves know sufficiently well what
> they are doing.

OK. I'll defer your judgement on what Windows users prefer. I just
wanted to make sure it was a conscious decision.

Other than that, the patch looks obviously correct to me. Thanks, and
sorry for inadvertently breaking git on windows (again). :)

-Peff