From: Clemens Buchacher <drizzd@aon.at>
Date: Tue, 17 Apr 2012 21:45:22 GMT
Subject: Re: [PATCH v6 2/4] git-cherry-pick: Add keep-redundant-commits option
Message-ID: <20120417214521.GB19908@ecki>
In-Reply-To: <1334686809-17634-3-git-send-email-nhorman@tuxdriver.com>

On Tue, Apr 17, 2012 at 02:20:07PM -0400, Neil Horman wrote:
>
> +	if (!empty && !opts->keep_redundant_commits && index_unchanged)
> +			/*
> +			 * The head tree and the index match
> +			 * meaning the commit is empty.  Since it wasn't created
> +			 * empty (based on the previous test), we can conclude
> +			 * the commit has been made redundant.  Since we don't
> +			 * want to keep redundant commits, we can just return
> +			 * here, skipping this commit
> +			 */
> +			return 0;

You can remove one level of indentation (yay!).