From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 16 Apr 2012 00:38:50 GMT
Subject: Re: [PATCH] completion: fix issues with COMP_WORDBREAKS
Message-ID: <20120416003850.GH5813@burratino>
In-Reply-To: <1334524654-13482-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras wrote:

> In fact if COMP_WORDBREAKS doesn't contain a colon the completion gets
> all messed up. For example:
>
>  git push origin master:<TAB>
>  git diff master:<TAB>
>
> The "master:" prefix would be added again, unnecessarily.

Thanks.  Yeah, that sounds broken.

Unfortunately the patch introduces a regression: if after loading the
completion script I set COMP_WORDBREAKS not to contain a colon, then
with the current completion script

	git show HEAD:Docu<TAB>

completes fine, but with the patched completion script it seems to
get confused and strips off the HEAD.

Ideas?
Jonathan