From: Jeff King <peff@peff.net>
Date: Sat, 14 Apr 2012 02:26:04 GMT
Subject: Re: [PATCH/RFC] checkout --detached test: write supporting files before start of tests
Message-ID: <20120414022604.GB17535@sigill.intra.peff.net>
In-Reply-To: <20120413234949.GF13995@burratino>

On Fri, Apr 13, 2012 at 06:49:49PM -0500, Jonathan Nieder wrote:

> Jeff King wrote:
> 
> >                                                If anything, should this
> > not be moving the cat inside the test_expect_success?
> 
> That would be fine with me.  It would involve changing the ' around
> "master" to '\'' and would mean that if some later patch wants to use
> the same message, the author will have to remember to factor it out.

Ah, yeah, that is probably why I left it outside the test in the first
place.

> On the other hand, nothing about the message is specific to that test
> assertion, so I am ok with the patch I sent, too.

I don't care much either way. I just know that there are a million other
places that set up "expect" right before the test, so it seems like a
common exception to our rule.

-Peff