From: Jonathan Nieder Date: Fri, 13 Apr 2012 18:30:49 GMT Subject: Re: [PATCH v2 4/4] completion: improve 'git --exec-path' completion Message-ID: <20120413183048.GB2387@burratino> In-Reply-To: <20120413180436.GA2387@burratino> Jonathan Nieder wrote: > In other words, how about something like this? Tests left as an exercise > to the interested reader. ... and here's a simpler way to spell it. -- >8 -- Subject: completion: do not add trailing space when completing --exec-path --exec-path looks like to the completion script like an unambiguous successful completion, but it is wrong. The user could be trying to do git --exec-path; # print name of helper directory or git --exec-path=/path/to/alternative/helper/dir so the most helpful thing to do is to leave out the trailing space and leave it to the operator to type an equal sign or carriage return according to the situation. Reported-by: Felipe Contreras Signed-off-by: Jonathan Nieder --- contrib/completion/git-completion.bash | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 31f714da..d2109897 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -2639,6 +2639,7 @@ _git () --bare --version --exec-path + --exec-path= --html-path --work-tree= --namespace= -- 1.7.10