From: SZEDER Gábor <szeder@ira.uka.de>
Date: Fri, 13 Apr 2012 10:52:38 GMT
Subject: Re: [PATCH v2] tests: add initial bash completion tests
Message-ID: <20120413105238.GE2164@goldbirke>
In-Reply-To: <CAMP44s0_WQNpkVi0yMfaDgzBaUWOhRiS-2qxLtCHFzx71yKrSw@mail.gmail.com>

On Fri, Apr 13, 2012 at 01:34:46PM +0300, Felipe Contreras wrote:
> >> +     run_completion "git f" &&
> >> +     ! grep -q -v "^f" out
> >
> > grep is not a git command, so I'm not sure, but shouldn't these use
> > 'test_must_fail grep' instead of '! grep'?
> 
> I'm not sure. Junio has already queued this, maybe you should send a
> patch on top of that.

It seems that both are used in the test suite, but '! grep' is more
common, so perhaps it's good as it is.

$ git grep '! grep' -- t |wc -l
136
$ git grep 'test_must_fail grep' -- t |wc -l
17