From: Eric Wong <normalperson@yhbt.net>
Date: Tue, 10 Apr 2012 21:17:32 GMT
Subject: Re: [PATCH] prohibit "svn dcommit" on remote-tracking-branches
Message-ID: <20120410211732.GB27555@dcvr.yhbt.net>
In-Reply-To: <20120404084234.GA17768@mathe-macht-spass.de>

Christian Engwer <christian.engwer@wwu.de> wrote:
> A branch should either be a local copy of an svn branch, or a remote
> tracking branch. After a "git svn dcommit" a remote tracking branch
> could not be synced with the git remote due to the rebase that occured
> during the dcommit. Thus we check for a remote entry in the git config
> for the current branch and prohibit the "dcommit" if such an entry
> exists.

Should there be an option to force/override this?

git-svn predates remote tracking branches, and I've never gotten in the
habit using remote tracking branches.  I'll wait for others to chime
in...

> +        if (s/^\* +//)
> +        {

style, opening brace should be on the same line as the if/while/for:

	if (...) {

Also, indentation should be with hard tabs.  (Basically follow existing
style conventions when you see them).  Thanks.