From: Jeff King Date: Sun, 08 Apr 2012 11:06:42 GMT Subject: Re: [PATCH 01/12] tests: add initial bash completion tests Message-ID: <20120408110642.GB21217@sigill.intra.peff.net> In-Reply-To: <20120408103002.GA3177@burratino> On Sun, Apr 08, 2012 at 05:30:02AM -0500, Jonathan Nieder wrote: > > This test fails for me. The problem is that I have other git-f* programs > > in my PATH > [...] > Is there some reason we care about the exact list of completions for > "git f"? > [...] > Maybe it would make sense to check a few representative items. > > # builtin > grep "^fetch\$" out && I think your approach (to stop worrying about stopping pollution from the environment, and start being more specific in what the tests care about) is much saner than the snippet I posted. -Peff