From: Jonathan Nieder <jrnieder@gmail.com>
Date: Fri, 06 Apr 2012 00:42:26 GMT
Subject: Re: [PATCH] compat/mingw.[ch]: Change return type of exec functions to int
Message-ID: <20120406004226.GA2658@burratino>
In-Reply-To: <20120406002454.GB14224@sigill.intra.peff.net>

Jeff King wrote:

> I think both (attempt to) document the same thing: that if we get past
> execvp, we know are in error-checking mode. Which is not explicitly said
> anywhere. So maybe:
>
> diff --git a/run-command.c b/run-command.c
> index 7123436..e6ece79 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -117,10 +117,12 @@ static int exists_in_PATH(const char *file)
>  
>  int sane_execvp(const char *file, char * const argv[])
>  {
> -	if (!execvp(file, argv))
> -		return 0;
> +	execvp(file, argv);
>  
>  	/*
> +	 * If we are still running, we know an error occurred; let's try to
> +	 * diagnose it more specifically.
> +	 *
>  	 * When a command can't be found because one of the directories

Looks fine to me. :)

Thanks for your patience.
Jonathan