From: Jeff King Date: Mon, 02 Apr 2012 20:42:21 GMT Subject: Re: [PATCH v3 1/4] fetch-pack: new --stdin option to read refs from stdin Message-ID: <20120402204220.GC26503@sigill.intra.peff.net> In-Reply-To: <4F79C22C.9080702@gmx.net> On Mon, Apr 02, 2012 at 05:13:48PM +0200, Ivan Todoroski wrote: > + else { > + /* read from stdin one ref per line, until EOF */ > + struct strbuf line; > + strbuf_init(&line, 0); A minor style nit, but we usually spell this: struct strbuf line = STRBUF_INIT; Other than that, this version looks good to me. Thanks. -Peff