From: Jakub Narebski <jnareb@gmail.com>
Date: Fri, 30 Mar 2012 13:37:38 GMT
Subject: Re: [PATCH v2 3/8] gitweb: Extract print_sidebyside_diff_lines()
Message-ID: <201203301537.39429.jnareb@gmail.com>
In-Reply-To: <20120329192557.4bd45322@gmail.com>

On Thu, 29 Mar 2012, Michał Kiedrowicz wrote:
> Jakub Narebski <jnareb@gmail.com> wrote:
> > On Fri, 23 Mar 2012, Michał Kiedrowicz wrote:

> > > This is a preparation patch for diff refinement highlightning.  It should
> > > not change the gitweb output, but it slightly changes its behavior.
> > > Before this commit, context is printed on the class change. Now, it'it
> > > printed just before printing added and removed lines.
> > 
> >                                                       , and at the end
> >   of chunk.

Please don't forget to add that information.  I was wondering about this,
and checked code that it works all right.

> > IMVHO such change is irrelevant.

This refers to "but it slightly changes its behavior", which might be
not clear from the position of this sentence.

> > Acked-by: Jakub Narębski <jnareb@gmail.com>
> 
> Thanks.

-- 
Jakub Narebski
Poland