From: Jakub Narebski <jnareb@gmail.com>
Date: Thu, 29 Mar 2012 16:14:42 GMT
Subject: Re: [PATCH v2 5/8] gitweb: Move HTML-formatting diff line back to process_diff_line()
Message-ID: <201203291814.42803.jnareb@gmail.com>
In-Reply-To: <1332543417-19664-6-git-send-email-michal.kiedrowicz@gmail.com>

On Fri, 23 Mar 2012, Michał Kiedrowicz wrote:

> Commit 6ba1eb51b (gitweb: Add a feature to show side-by-side diff,
> 2011-10-31) for no special reason moved wrapping diff line in <div> out
> of format_diff_line(). Bring back old behavior.
> 
I remember that originally process_diff_line was format_diff_line... 

> This simplifies code in git_patchset_body() and keeps formatting of a
> diff line in one place.
> 
That is a good enough reason for me.

> The more long-term purpose of this patch is to move formatting diff
> lines down to print_diff_chunk(), to allow processing lines without
> HTML-formatting.
> 
Excuse me, but from this commit message (and from the patch itseld)
I don't see how this commit (patch) can help with this goal (and
don't remember details of discussion).

Please explain it in more detail, or simply remove above paragraph.

> This is just a refactoring patch. It's not meant to change gitweb
> output.
> 
> Signed-off-by: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>
> Acked-by: Jakub Narębski <jnareb@gmail.com>
> ---
[...]
-- 
Jakub Narebski
Poland