From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 28 Mar 2012 20:51:33 GMT
Subject: Re: [PATCH 2/2] git: continue alias lookup on EACCES errors
Message-ID: <20120328205133.GF8982@burratino>
In-Reply-To: <20120328203758.GA10104@sigill.intra.peff.net>

Jeff King wrote:
> On Wed, Mar 28, 2012 at 04:18:51PM -0400, Jeff King wrote:

>> +int sane_execvp(const char *file, char * const argv[])
>> +{
>> +	int ret = execvp(file, argv);
>> +	if (ret < 0 && errno == EACCES && !file_in_path_is_nonexecutable(file))
>> +		errno = ENOENT;
>> +	return ret;
>> +}
>
> Hmm, this should check for (*file == '/') to handle absolute paths
> properly.

Or rather for "strchr(file, '/')", because "path/to/cmd" does not mean to
append that string to each term of $PATH.