From: Jeff King <peff@peff.net>
Date: Wed, 28 Mar 2012 04:30:58 GMT
Subject: Re: [PATCH 2/2] git: continue alias lookup on EACCES errors
Message-ID: <20120328043058.GD30251@sigill.intra.peff.net>
In-Reply-To: <7v4nt9j1m3.fsf@alter.siamese.dyndns.org>

On Tue, Mar 27, 2012 at 12:16:36PM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > If git receives an EACCES error while trying to execute an
> > external command, we currently give up and report the error.
> > However, the EACCES may be caused by an inaccessible
> > directory in the user's PATH.
> 
> Regardless of EACCES/ENOENT change we discussed, the observable behaviour
> should be testable.  Something like this?

Yes, though I held back on writing tests, because I don't think we've
quite decided what the behavior _should_ be. Should we be
differentiating "chmod -x /bin/ls" from "chmod -x /bin"? Should we be
continuing alias lookup on EACCES? Should we print edit-distance
suggestions on EACCES?

I think the four cases from my previous email would be reasonable things
to test, but I wasn't sure what the expected outcomes should look like.

-Peff