From: Jeff King <peff@peff.net>
Date: Thu, 22 Mar 2012 19:07:05 GMT
Subject: Re: [PATCH] Demonstrate failure of 'core.ignorecase = true'
Message-ID: <20120322190705.GB27037@sigill.intra.peff.net>
In-Reply-To: <7viphwxyp1.fsf@alter.siamese.dyndns.org>

On Thu, Mar 22, 2012 at 11:44:42AM -0700, Junio C Hamano wrote:

> I wanted it to tell *what* happens when core.ignorecase is set.  In other
> words, I wanted the description to say that the logic employed is to work
> around what case-insensitive filesystems do.  Case sensitive filesystems
> obviously do not do what case-insensitive ones do (like reporting a
> "Makefile" exists when only "makefile" exists), so I hoped that it was
> clear enough that the additional logic would not be suitable there.

Ah. I see now why you made the change you did. But if I missed it,
perhaps it was too subtle (of course, I found the other one perfectly
adequate, so...).

> I guess we really need to make the description foolproof then.
> 
>                    ... exists on them is "makefile". By setting this
> 	variable to `true`, Git employs logic to work around them.
>         Setting this to `true` on a case insensitive filesystem does
> 	not make any sense, because it would not magically make your
> 	system to treat your filesystem case insensitively.

I'm OK with that (modulo s/insensitive/sensitive/ on the third line).
It may be overly explicit, but I would rather err on that side.

-Peff