From: Jeff King <peff@peff.net>
Date: Thu, 15 Mar 2012 03:56:42 GMT
Subject: Re: [PATCH v2 1/2] t0303: immediately bail out w/o GIT_TEST_CREDENTIAL_HELPER
Message-ID: <20120315035642.GB4149@sigill.intra.peff.net>
In-Reply-To: <1331734704-14281-1-git-send-email-zbyszek@in.waw.pl>

On Wed, Mar 14, 2012 at 03:18:23PM +0100, Zbigniew Jędrzejewski-Szmek wrote:

> -pre_test() {
> -	test -z "$GIT_TEST_CREDENTIAL_HELPER_SETUP" ||
> -	eval "$GIT_TEST_CREDENTIAL_HELPER_SETUP"
> [...]
> +$GIT_TEST_CREDENTIAL_HELPER_SETUP

Except for losing the eval here that Junio mentioned, I think both
patches look good.

-Peff