From: Jeff King <peff@peff.net>
Date: Tue, 13 Mar 2012 20:48:26 GMT
Subject: Re: [PATCH] diff: Introduce diff.algorithm variable
Message-ID: <20120313204826.GA27436@sigill.intra.peff.net>
In-Reply-To: <7v399cxuk9.fsf@alter.siamese.dyndns.org>

On Tue, Mar 13, 2012 at 10:46:46AM -0700, Junio C Hamano wrote:

> Tay Ray Chuan <rctay89@gmail.com> writes:
> 
> > Considering that --minimal isn't really an algorithm,...
> 
> I think this discussion thread already settled that "minimal" *is* an
> algorithm for the purpose of this topic, considering that the --minimal
> option does not apply anything but myers.

I don't know that it is settled. I proposed it as a concept, and nobody
else objected. It is true that right _now_ --minimal doesn't do anything
for non-myers algorithms, but in theory it could. IOW, it is a matter of
the user's perspective whether the flag is "use the minimal Myers diff
algorithm" versus "spend extra effort to make the diff more minimal, no
matter which algorithm is being used". If the latter, it is only that we
have not (yet) implemented the extra effort tweaks to the other
algorithms.

So I think we could go either way.

-Peff