From: Jeff King Date: Thu, 08 Mar 2012 07:15:59 GMT Subject: Re: [PATCH] archive: fix archive generation for empty trees Message-ID: <20120308071559.GF7643@sigill.intra.peff.net> In-Reply-To: <7vpqcnfvhs.fsf@alter.siamese.dyndns.org> On Wed, Mar 07, 2012 at 10:38:07PM -0800, Junio C Hamano wrote: > > ... However, prefix_pathspec does a lot of magic parsing; > > it's unclear to me whether this is all in support of properly > > adding the prefix, or if its side effects are important. > > These "magic" are for things like :(root)/path that will explicitly > refuse the prefix when run from a subdirectory. Yeah, that was my impression. In that case, I would think we could get rid of the get_pathspec call entirely, as it is purely about fixing-up prefixes, and we know that we have none. -Peff