From: Tom Grennan <tmgrennan@gmail.com>
Date: Sat, 03 Mar 2012 17:33:50 GMT
Subject: Re: [PATCHv2 2/5] t5512 (ls-remote): modernize style
Message-ID: <20120303173350.GL2572@tgrennan-laptop>
In-Reply-To: <7vipim6rf2.fsf@alter.siamese.dyndns.org>

On Sat, Mar 03, 2012 at 12:05:05AM -0800, Junio C Hamano wrote:
>Tom Grennan <tmgrennan@gmail.com> writes:
>
>>  test_expect_success 'confuses pattern as remote when no remote specified' '
>> +	'"
>> +	cat >exp <<-EOF
>> +		fatal: 'refs*master' does not appear to be a git repository
>> +		fatal: The remote end hung up unexpectedly
>> +	EOF
>> +	"'
>
>Please make it a habit to make your test script a cascade of &&, i.e.
>
>	... remote specified' '
>	cat >exp <<-\EOF &&
>        fatal: '\''refs*master'\'' does not ...
>	...
>        EOF
>
>No need to resend; I'll fix it up locally.        
>

Oops, I missed the && on that one.

What about the quoting of t6300's,

cat >expected <<\EOF
'refs/heads/master' 'Mon Jul 3 17:18:43 2006 +0200' 'Mon Jul 3 17:18:44 2006 +0200'
'refs/tags/testtag' 'Mon Jul 3 17:18:45 2006 +0200'
EOF

Do you want it like this,
	cat >expected <<-EOF &&
		'\''refs/heads/master'\'' '\''Mon Jul 3 17:18:43 2006 +0200'\'' '\''Mon Jul 3 17:18:44 2006 +0200'\''
		'\''refs/tags/testtag'\'' '\''Mon Jul 3 17:18:45 2006 +0200'\''
	EOF

or,
	cat >expected <<-EOF &&
		'"'refs/heads/master' 'Mon Jul 3 17:18:43 2006 +0200' 'Mon Jul 3 17:18:44 2006 +0200'"'
		'"'refs/tags/testtag' 'Mon Jul 3 17:18:45 2006 +0200'"'
	EOF

or something else?

Thanks,
TomG