From: Jeff King <peff@peff.net>
Date: Thu, 01 Mar 2012 21:01:29 GMT
Subject: Re: [PATCH v2 2/3] http: try http_proxy env var when http.proxy config option is not set
Message-ID: <20120301210129.GD17631@sigill.intra.peff.net>
In-Reply-To: <7vy5rkm91t.fsf@alter.siamese.dyndns.org>

On Thu, Mar 01, 2012 at 11:10:38AM -0800, Junio C Hamano wrote:

> Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes:
> 
> > CuRL already reads it, but if $http_proxy has username but no password
> > curl will not ask you for the password.. so we read it ourselves to
> > detect that and ask for the password.
> 
> Please stop the double-dot.  Also your capitalization for cURL is screwed
> up.
> 
> More importantly, please describe what happens after "will not ask".
> "will not ask you for the password and the connection fails"?
> "will not ask you for the password and the gives an error message saying
> 'authentication failure'"?

When we need to authenticate for the destination webserver, we detect an
HTTP 401, _then_ ask for the credentials, and retry the request. I'm
curious what the error condition is for the authentication failure, and
if we can do the same here (from a brief skim of rfc2616, it looks like
it should be a 407, but I do not even have a proxy set up to try).

-Peff