From: Tom Grennan <tmgrennan@gmail.com>
Date: Thu, 01 Mar 2012 15:58:07 GMT
Subject: Re: [PATCH 1/5] t6300 (for-each-ref): modernize style
Message-ID: <20120301155807.GH2572@tgrennan-laptop>
In-Reply-To: <4F4F1CD7.4060403@viscovery.net>

On Thu, Mar 01, 2012 at 07:53:11AM +0100, Johannes Sixt wrote:
>Am 3/1/2012 2:45, schrieb Tom Grennan:
>> +	git for-each-ref --format="%(refname)" --sort=refname |
>> +		test_cmp expect -
>
>DON'T DO THIS. It loses the exit code of the git invocation.
>
>(And it is contrary to my effort to move all test_cmp away from being used
>in a pipeline because I want to use a comparator tool that does not
>understand '-' as stdin.)

OK, with bash, one could get that from PIPESTATUS, but that doesn't help if
you're not using bash or desire a different comparator.

Thanks,
TomG