From: Jeff King Date: Wed, 22 Feb 2012 20:51:08 GMT Subject: Re: [PATCH 1/2] bundle: put strbuf_readline_fd in strbuf.c with adjustments Message-ID: <20120222205108.GC6781@sigill.intra.peff.net> In-Reply-To: On Wed, Feb 22, 2012 at 08:34:22PM +0100, Thomas Rast wrote: > The comment even said that it should eventually go there. While at > it, match the calling convention and name of the function to the > strbuf_get*line family. So it now is strbuf_getwholeline_fd. > [...] > bundle.c | 21 ++------------------- > strbuf.c | 16 ++++++++++++++++ > strbuf.h | 1 + Nit: no update to Documentation/technical/api-strbuf.txt. You might want to also mention that this will read() one byte at a time, and is therefore only a good idea if you really care about the position of the fd. Otherwise, fdopen() + strbuf_getwholeline() is much more efficient. -Peff