From: Eric Wong Date: Wed, 22 Feb 2012 00:33:17 GMT Subject: Re: [PATCH] git-svn.perl: fix a false-positive in the "already exists" test Message-ID: <20120222003317.GA1069@dcvr.yhbt.net> In-Reply-To: <1329747474-17976-1-git-send-email-stevenrwalter@gmail.com> Steven Walter wrote: > open_or_add_dir checks to see if the directory already exists or not. > If it already exists and is not a directory, then we fail. However, > open_or_add_dir did not previously account for the possibility that the > path did exist as a file, but is deleted in the current commit. > > In order to prevent this legitimate case from failing, open_or_add_dir > needs to know what files are deleted in the current commit. > Unfortunately that information has to be plumbed through a couple of > layers. > > Signed-off-by: Steven Walter Thanks, will push. Acked-by: Eric Wong