From: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>
Date: Mon, 13 Feb 2012 21:10:24 GMT
Subject: Re: [PATCH 6/8] gitweb: Highlight interesting parts of diff
Message-ID: <20120213221024.7315d3c0@gmail.com>
In-Reply-To: <201202132058.18001.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> wrote:

> Michal Kiedrowicz wrote:
> > Jakub Narebski <jnareb@gmail.com> wrote:
> > > Jakub Narebski <jnareb@gmail.com> writes:
> [...]
> > > > Anyway I have send to git mailing list a patch series, which in one
> > > > of patches adds esc_html_match_hl($str, $regexp) to highlight
> > > > matches in a string.  
> > 
> > Yeah, I saw that but after seeing that they accept different arguments
> > I decided to leave them alone.
> > 
> > > > Your esc_html_mark_range(), after a
> > > > generalization, could be used as underlying "engine".
> > > > 
> > > > Something like this, perhaps (untested):
> > 
> > I think I'll leave it to you after merging both these series to
> > master :)
>  
> Yes, you are right.  Let's do it when we actually need it.
> 

Good :)