From: Ted Ts'o <tytso@mit.edu>
Date: Mon, 06 Feb 2012 05:57:50 GMT
Subject: Re: [PATCH] Fix build problems related to profile-directed optimization
Message-ID: <20120206055750.GA6615@thunk.org>
In-Reply-To: <20120206041839.GB29365@sigill.intra.peff.net>

On Sun, Feb 05, 2012 at 11:18:39PM -0500, Jeff King wrote:
> > -	$ make profile-all
> > -	# make prefix=... install
> > +	$ make --prefix=/usr PROFILE=BUILD all
> > +	# make --prefix=/usr PROFILE=BUILD install
> 
> Eh? --prefix?

Oops, configure meme strikes; will fix.

> > +As a caveat: a profile-optimized build takes a *lot* longer since it
> > +is the sources have to be built twice, and in order for the profiling
> 
> s/it is//

Thanks, will fix.

> > +ifeq "$(PROFILE)" "GEN"
> > +	CFLAGS += -fprofile-generate=$(PROFILE_DIR) -DNO_NORETURN=1
> > +	EXTLIBS += -lgcov
> > +	export CCACHE_DISABLE=t
> > +	V=1
> > +else ifneq "$PROFILE" ""
> 
> Did you mean "$(PROFILE)" in the second conditional?

Yes, thanks.   Will fix.

						- Ted