From: Jeff King Date: Thu, 02 Feb 2012 11:07:19 GMT Subject: Re: [PATCH 0/9] respect binary attribute in grep Message-ID: <20120202110719.GA29870@sigill.intra.peff.net> In-Reply-To: <87vcnp5wkg.fsf@thomas.inf.ethz.ch> On Thu, Feb 02, 2012 at 12:00:47PM +0100, Thomas Rast wrote: > My original plan was to make use_threads git-global, instead of > grep-global (and shift responsibility to the subsystems instead of their > users), but that's just me and the patches aren't ready yet. Yeah, having just dug into the threading code in grep a bit, I agree that would be a saner approach. The locking is all bolted-on, so you end up with these weird contracts between code, like the low-level grep code asking anybody who might be multi-threading it to initialize the mutexes to cover access to a totally different subsystem. I'd much rather each subsystem just take care of itself. -Peff