From: Jonathan Nieder Date: Thu, 02 Feb 2012 00:31:18 GMT Subject: Re: [PATCH v2] Use correct grammar in diffstat summary line Message-ID: <20120202003118.GB3487@burratino> In-Reply-To: <20120201233515.GC29599@burratino> Jonathan Nieder wrote: > Nguyễn Thái Ngọc Duy wrote: >> --- a/t/t5150-request-pull.sh >> +++ b/t/t5150-request-pull.sh >> @@ -95,7 +95,7 @@ test_expect_success 'setup: two scripts for reading pull requests' ' >> b >> : diffstat >> n >> - / [0-9]* files changed/ { >> + / [0-9]* files\? changed/ { > > Mimicking a human. > > (**) Should probably use "*" instead of \? --- \? is a GNU extension, > not a BRE. ... and here's a patch making that change for convenience (also untested). --- t/t5150-request-pull.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh index 34c482f1..ec5f7368 100755 --- a/t/t5150-request-pull.sh +++ b/t/t5150-request-pull.sh @@ -95,7 +95,7 @@ test_expect_success 'setup: two scripts for reading pull requests' ' b : diffstat n - / [0-9]* files\? changed/ { + / [0-9]* files* changed/ { a\\ DIFFSTAT b -- 1.7.9