From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 30 Jan 2012 02:50:15 GMT
Subject: Re: [PATCH 3/3] completion: remove unused code
Message-ID: <20120130025014.GA15944@burratino>
In-Reply-To: <1327880479-25275-4-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras wrote:

> No need for thus rather complicated piece of code :)
[...]
>  contrib/completion/git-completion.bash |   30 ------------------------------
>  1 files changed, 0 insertions(+), 30 deletions(-)
[...]
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2730,33 +2730,3 @@ if [ Cygwin = "$(uname -o 2>/dev/null)" ]; then
[...]
> -if [[ -n ${ZSH_VERSION-} ]]; then
> -	__git_shopt () {
[...]
> -else
> -	__git_shopt () {
> -		shopt "$@"
> -	}
> -fi

What codebase does this apply to?  My copy of git-completion.bash
contains a number of calls to __git_shopt, which will fail after this
change.

By the way, is there any reason you did not cc this series to Gábor or
others who also know the completion code well?  The patches are not
marked with RFC/ so I assume they are intended for direct application,
which seems somewhat odd to me.

Thanks and hope that helps,
Jonathan