From: Peter Baumann <waste.manager@gmx.de>
Date: Sat, 14 Jan 2012 15:23:16 GMT
Subject: Re: [PATCH v3 1/3] Eliminate recursion in setting/clearing marks in commit list
Message-ID: <20120114152316.GA30986@m62s10.vlinux.de>
In-Reply-To: <1326543595-28300-2-git-send-email-pclouds@gmail.com>

On Sat, Jan 14, 2012 at 07:19:53PM +0700, Nguyễn Thái Ngọc Duy wrote:
> Recursion in a DAG is generally a bad idea because it could be very
> deep. Be defensive and avoid recursion in mark_parents_uninteresting()
> and clear_commit_marks().
> 
> mark_parents_uninteresting() learns a trick from clear_commit_marks()
> to avoid malloc() in (dorminant) single-parent case.
                        ^^^^^^^^^

I think you ment dominant here.