From: Jonathan Nieder Date: Sun, 08 Jan 2012 20:48:15 GMT Subject: Re: [PATCH 2/6] revert: decouple sequencer actions from builtin commands Message-ID: <20120108204815.GP1942@burratino> In-Reply-To: Ramkumar Ramachandra wrote: > Jonathan Nieder wrote: >> Ramkumar Ramachandra wrote: >>> Jonathan Nieder wrote: >>>> So what change does the patch actually make?  Is this a renaming? >>> >>> Yes, it renames "action" to "command" where appropriate. >> >> Wouldn't a simple renaming have a diffstat with the same number of added >> and removed lines? > > Yes, almost. A few extra lines added because I needed a new data enum > for the "command"; also added a convenience function: action_name(). It's not a simple renaming, then. What user-visible effect will this have, if any? What programmer-visible effect will it have, if any? I _really_ should not have to read the patch to learn the impact of a patch.